Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gog): make sure game directory is mounted in container #4251

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

imLinguin
Copy link
Member

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 7, 2025
@imLinguin imLinguin requested review from a team, arielj, flavioislima, CommandMC and Nocccer and removed request for a team January 7, 2025 23:49
@arielj
Copy link
Collaborator

arielj commented Jan 8, 2025

how can we test this? like, how can we reproduce the problem this is fixing to know what to look for?

@Etaash-mathamsetty
Copy link
Member

code looks fine, but is this only an issue with gog ?

@imLinguin
Copy link
Member Author

it might affect others as well, I haven't experienced any issues though...

@imLinguin
Copy link
Member Author

what this essentially does is allows to mount game directory during setup. This is crucial especially when mount point is in non-standard location that is not handled by pressure vessel out of the box

@arielj
Copy link
Collaborator

arielj commented Jan 8, 2025

Sorry, not sure what you mean by mount, you mean using the game's install folder as the current working directory?

@imLinguin
Copy link
Member Author

soldier and sniper runtimes are container based and have limited list of paths they expose in container by default. Adding STEAM_COMPAT_INSTALL_PATH env variable does exactly that, makes sure container exposes game directory.
Current working directory was another addition I had to make in order for setup to succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants