Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Warn when Shader Pre-Cache is disabled and using umu in SD's gaming mode #4328

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Feb 6, 2025

This PR adds new information in the logs to help both users and support, this is more important now that we are going to default to umu and we already recommend umu to users over discord.

When using umu on the SteamDeck's gaming mode, it looks for the steam app id in different environment variables that are only defined when the Steam's Shader Pre-Cache is enabled.

When all those conditions are met, the logs will now include a warning message to instruct the users that this is not enabled and the game may not work properly.

More details: https://github.com/Open-Wine-Components/umu-launcher/wiki/Frequently-asked-questions-(FAQ)#why-am-i-not-able-to-see-my-game-when-using-my-launcher-from-steam-mode-gaming-mode


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Feb 6, 2025
@arielj arielj requested review from Etaash-mathamsetty, a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team February 6, 2025 23:10
@Etaash-mathamsetty
Copy link
Member

Etaash-mathamsetty commented Feb 7, 2025

I dug through the original issue on gamescope's GitHub and it seems that this has been fixed in UMU already. Probably should double check though

@arielj
Copy link
Collaborator Author

arielj commented Feb 7, 2025

I dug through the original issue on gamescope's GitHub and it seems that this has been fixed in UMU already. Probably should double check though

The umu FAQ says it's needed, and this is a message from last week saying it's a hard requirement, not something that can be fixed by umu Open-Wine-Components/umu-launcher#92 (comment)

@Etaash-mathamsetty
Copy link
Member

Etaash-mathamsetty commented Feb 7, 2025

Hmm I guess GE was referring to some other issue being fixed with python-xlib then ?
I'll test it with actual hardware tmrw, but either way I feel like this needs to be fixed gamescope side

@arielj
Copy link
Collaborator Author

arielj commented Feb 7, 2025

Hmm I guess GE was referring to some other issue being fixed with python-xlib then ? I'll test it with actual hardware tmrw, but either way I feel like this needs to be fixed gamescope side

it doesn't seem to be a gamescope issue either? umu needs the steam app id to properly handle the screens changing, and it gets the id from those env variables

the issue seems to be that the only way to get those env variables to be populated is with the Shader Pre-Caching enabled

I understand the issue would be solved if the SteamOS or its variants would just add an ENV variable or a simpler way to just get the steam app id directly without unrelated env variables parsing

EDIT: also, I can confirm the issue, I tested it too when it was discussed in a Discord thread, you disable Shader Pre-Caching and then games stops working with umu in gaming mode (well, the game works, but the steam loading screen is not removed, the game works in the background)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants