Miscellaneous build warning fixes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdelfin
commented
Oct 7, 2020
Comment on lines
-352
to
-360
| float Pandar20_elev_angle_map_[HS_LIDAR_L20_UNIT_NUM]; | ||
| float Pandar20_horizatal_azimuth_offset_map_[HS_LIDAR_L20_UNIT_NUM]; | ||
|
|
||
| float PandarQT_elev_angle_map_[HS_LIDAR_QT_UNIT_NUM]; | ||
| float PandarQT_horizatal_azimuth_offset_map_[HS_LIDAR_QT_UNIT_NUM]; | ||
|
|
||
| float PandarXT_elev_angle_map_[HS_LIDAR_XT_UNIT_NUM]; | ||
| float PandarXT_horizatal_azimuth_offset_map_[HS_LIDAR_XT_UNIT_NUM]; | ||
|
|
There was a problem hiding this comment.
These are unused private fields. Are they here for a reason?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a number of build warning/errors that popped up after I started building this code using a build system setup with slightly more strict compiler flags. All these changes should have no behavioural effect on the SDK. As a warning, these bugs seem to also be present in the version of this SDK embedded inside the ROS repo.