Adding validations to rest APIs #226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varkha-d-sharma
requested review from
annmary-roy,
varkha-d-sharma,
AyeshaSanadi,
rishabhsharma22 and
shreyas-kulkarni09
and removed request for
varkha-d-sharma
shreyas-kulkarni09
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
PR looks good to me. @rishabhsharma22 can you please check if any updated packages are not breaking any features.
server/app/main.py
Outdated
|
|
||
| # api to get mlmd file from cmf-server | ||
| @app.get("/mlmd_pull/{pipeline_name}", response_class=HTMLResponse) | ||
| async def mlmd_pull(info: Request, pipeline_name: str): | ||
| async def mlmd_pull(pipeline_name: str, request: MLMDPullRequest): |
There was a problem hiding this comment.
It's not a good practice to include body in GET request. "exec_id" id can be part of uri
There was a problem hiding this comment.
Hi @shreyas-kulkarni09, I changed the mlmd_pull request to accept exec_id as a query parameter instead of in the JSON body. Thanks for the heads-up!
shreyas-kulkarni09
approved these changes
Feb 13, 2025
|
PR looks good to me. I think the issue that @shreyas-kulkarni09 has raised must be addressed and we are good to merge it. |
Jaychaware
force-pushed
the
rest_api_validation
branch
from
27ca4fc to
a8c44c1
Compare
Jaychaware
force-pushed
the
rest_api_validation
branch
from
a8c44c1 to
c0ed27e
Compare
shreyas-kulkarni09
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues / Pull Requests
Description
Using Pydantic library, added validations to rest APIs
What changes are proposed in this pull request?
Checklist:
uses Google-style formatting and any other formatting that is supported by mkdocs and plugins this project
uses.