Support image digests in FROM instructions #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry my IDE introduced a some indenting changes here, which artificially blows up the diff. I'll make sure to remove those before merge. |
|
It'll be pretty useful to have this PR or #15 merged to unblock dprint/dprint-plugin-dockerfile#9. |
|
ping @jonmcquillan |
|
Sorry it took so long to get to looking at this. Can you merge in master to kick off the github actions I migrated the repo to? @jayvdb |
|
ping @thundergolfer ;-) |
|
@jayvdb done |
jonmcquillan
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-up of #15, but updates the test code to be compatible with current APIs and also includes some additional validation of the digest part (with tests).