configure.ac: use AC_USE_SYSTEM_EXTENSIONS #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
functions like splice(2) and sched_setaffinity(2), used in netperf, require _GNU_SOURCE to be declared. without it, we see warnings about missing definitions. once upon a time, AC_GNU_SOURCE would have pulled this in where appropriate, but that's just an alias these days for AC_USE_SYSTEM_EXTENSIONS. with this added, we no longer see the warnings on linux.
luckyh
added a commit
to luckyh/avocado-vt
that referenced
this pull request
Jun 17, 2024
Starting from gcc 14.0, implicit function declarations are treated as errors by default [1], which caused the following failure been observed during the compilation. > netlib.c:2343:9: error: implicit declaration of function ... > ... > make[3]: *** [Makefile:454: netlib.o] Error 1 One contributor has already sent a PR [2] to fix the issue to the netperf upstream, however, it has not been merged yet since a year ago. At the moment, let's just bypass this issue, while waiting for a regular fix to be done. References: [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91092 [2] HewlettPackard/netperf#74 Signed-off-by: Xu Han <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functions like splice(2) and sched_setaffinity(2), used in netperf, require _GNU_SOURCE to be declared. without it, we see warnings about missing definitions. once upon a time, AC_GNU_SOURCE would have pulled this in where appropriate, but that's just an alias these days for AC_USE_SYSTEM_EXTENSIONS. with this added, we no longer see the warnings on linux.