Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cancel process from vacancies #760

Merged
merged 13 commits into from
Aug 30, 2024
Merged

add cancel process from vacancies #760

merged 13 commits into from
Aug 30, 2024

Conversation

usernaimandrey
Copy link
Contributor

@usernaimandrey usernaimandrey commented Jul 7, 2024 •
edited
Loading

Снимок экрана от 2024-07-09 01-58-37
Снимок экрана от 2024-07-09 01-58-11

@usernaimandrey usernaimandrey marked this pull request as draft July 7, 2024 22:36
@usernaimandrey
Copy link
Contributor Author

#757

@usernaimandrey usernaimandrey marked this pull request as ready for review July 8, 2024 22:59
@HelenOne
Copy link
Contributor

Can you please deploy so we can check it visually?

@fey
Copy link
Collaborator

fey commented Jul 16, 2024

@usernaimandrey zadeploy demo plz -)

@fey
Copy link
Collaborator

fey commented Jul 19, 2024

@usernaimandrey Is it ready and can be reviewed? Or will there be more tweaking to be done?

@usernaimandrey
Copy link
Contributor Author

@usernaimandrey Is it ready and can be reviewed? Or will there be more tweaking to be done?

Привет! Сегодня работу с нотификациями еще закину и все

Задеплоить демку куда то не обещаю так как бесплатные периоды на рендере и railway закаончились

@usernaimandrey
Copy link
Contributor Author

Можно ревьюить)

@fey
Copy link
Collaborator

fey commented Jul 22, 2024

@usernaimandrey визуально вроде ок.

@fey
Copy link
Collaborator

fey commented Jul 22, 2024

@usernaimandrey наверное в фикстуры можно добавить отклоненнуюв акансию + уведомление

@usernaimandrey
Copy link
Contributor Author

@usernaimandrey наверное в фикстуры можно добавить отклоненнуюв акансию + уведомление

Приветы добавил https://github.com/Hexlet/hexlet-cv/pull/760/files#diff-2c100dd4ab7c69690757b0077c937e0bd0b6df3f5071c5cc2049ac4e56fa47e7

@amshkv amshkv requested a review from corsicanec82 July 23, 2024 08:29
corsicanec82
corsicanec82 requested changes Jul 25, 2024
View reviewed changes
app/controllers/web/admin/vacancies_controller.rb Outdated Show resolved Hide resolved
app/controllers/web/admin/vacancies_controller.rb Outdated Show resolved Hide resolved
app/models/vacancy.rb Outdated Show resolved Hide resolved
app/models/vacancy.rb Outdated Show resolved Hide resolved
app/models/vacancy.rb Show resolved Hide resolved
test/fixtures/vacancies.yml Outdated Show resolved Hide resolved
app/views/web/admin/vacancies/_cancelation_form.html.slim Outdated Show resolved Hide resolved
app/views/web/admin/vacancies/new_cancelation.html.slim Outdated Show resolved Hide resolved
config/locales/admin/ru.yml Outdated Show resolved Hide resolved
app/views/web/admin/vacancies/new_cancelation.html.slim Outdated Show resolved Hide resolved
@usernaimandrey
Copy link
Contributor Author

Все по фиксил

corsicanec82
corsicanec82 requested changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@corsicanec82 corsicanec82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почти всё ок. Есть пару небольших неточностей плюс предлагаю несколько упрощений.

app/mutators/admin/vacancy_mutator.rb Show resolved Hide resolved
config/locales/en.activerecord.yml Outdated Show resolved Hide resolved
app/models/vacancy.rb Outdated Show resolved Hide resolved
config/locales/en.views.yml Outdated Show resolved Hide resolved
app/mutators/admin/vacancy_mutator.rb Outdated Show resolved Hide resolved
app/models/notification.rb Outdated Show resolved Hide resolved
app/mutators/admin/vacancy_mutator.rb Show resolved Hide resolved
@fey fey linked an issue Aug 6, 2024 that may be closed by this pull request
Добавить возможность отклонения вакансии #757
Closed
@fey
Copy link
Collaborator

fey commented Aug 12, 2024

@usernaimandrey Ну как успехи

@usernaimandrey
Copy link
Contributor Author

@usernaimandrey Ну как успехи

Я пока в отпуске, после 18 августа вернусь, внесу правки по предложению Стаса, тут немного осталось)

@fey
Copy link
Collaborator

fey commented Aug 12, 2024

@usernaimandrey хорошего отдыха!

@usernaimandrey
Copy link
Contributor Author

@usernaimandrey хорошего отдыха!

Спасибо

@usernaimandrey usernaimandrey force-pushed the feat/757/add_canceled_process_from_vacancies branch from 61ed5aa to 528b27a Compare August 18, 2024 19:32
corsicanec82
corsicanec82 reviewed Aug 19, 2024
View reviewed changes
.ruby-version Outdated Show resolved Hide resolved
app/mutators/admin/vacancy_mutator.rb Show resolved Hide resolved
@grozwalker
Copy link
Contributor

grozwalker commented Aug 19, 2024 •
edited
Loading

Я пока в отпуске, после 18 августа вернусь, внесу правки по предложению Стаса, тут немного осталось)

ин инглиш, плиз

@fey
Copy link
Collaborator

fey commented Aug 26, 2024 •
edited
Loading

ин инглиш, плиз

Mal'chik, review prinesi, my feature hotim.
image

corsicanec82
corsicanec82 requested changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@corsicanec82 corsicanec82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В целом всё ок. Оставил буквально пару небольших комментов, которые по сути не оч критичны

app/models/vacancy.rb Outdated Show resolved Hide resolved
app/mutators/admin/vacancy_mutator.rb Outdated Show resolved Hide resolved
app/controllers/web/admin/vacancies_controller.rb Outdated Show resolved Hide resolved
app/controllers/web/admin/vacancies_controller.rb Outdated Show resolved Hide resolved
app/controllers/web/admin/vacancies_controller.rb Show resolved Hide resolved
@corsicanec82 corsicanec82 merged commit fb36e9b into Hexlet:main Aug 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fey fey fey left review comments

@corsicanec82 corsicanec82 corsicanec82 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Добавить возможность отклонения вакансии
5 participants
@usernaimandrey @HelenOne @fey @grozwalker @corsicanec82