-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Setup Wizard #1165
base: main
Are you sure you want to change the base?
Initial Setup Wizard #1165
Conversation
Hello, thanks for your contribution! I really like the UI. I noticed a couple of issues with UX and functionality:
There are also numerous whitespace/style changes. If you can remove them that will make it easier for me to do a deeper review. |
Please ignore the review by |
I did a manual test just now but I think I did it too early. Let me know when this PR is ready for me to test again. In case it's helpful though, here's a recording of my test anyway. pr-1165_1.6x.mp4 |
randomly generated passwords are used when the user first boots up puter, and new passwords are shown in the dev console for the sake of tracking. These passwords are updated immediately if changed.
I’ve gotten to a point where changes are being made directly to the correct config.json file, right now the only thing I have left so far to change is reverting the nip.io domain value if the user decided to go back to the setup wizard. I’ve also reduced some files so that the user only needs to delete ./volatile/runtime/config/setup-completed Could you please test out whether or not my implementation is correct for IP-based configuration? At the moment I’ve just left the nip.io domain to use the local port, just figuring out an automated way to change config.json to go back to localhost, but currently just changing the file directly works as intended |
Hi, I got your message on Slack earlier. I've done another manual test. There seem to be some additional issues.
Here's a recording of my manual text (1.5x speed for convenience) pr-1165_mt-2_1.5x.mp4 |
Tasks:
Steps to use the wizard (can be found in README):
npm start
after cloning puter filesTo return to the wizard for different configuration settings:
In the /puter directory, run the following commands:
and confirm removal. You may also navigate into the appropriate directory and directly delete the files.
Run
npm start
. The setup wizard should reappear with default configurations.