Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak: reorder and fix Farsi translation of i18n keys #1169

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shushannap
Copy link

(Complete Farsi translation based on English file #535)

  • Analyze en.js and fa.js file to find discrepencies
  • Reorder fa.js to correctly match en.js in alphabetical order
  • Add comments to break up 2FA Setup, 2FA Login, Sharing, and Billing
  • Delete comments of English translations in fa.js
  • Kept translation notes from previous translator
  • Ensure Farsi translations are close as possible to original source matter. All keys were already filled out. Upon review, no translation errors were found.



Contributor Questions:

  • Would you prefer I add back in the English translations into fa.js?
  • If yes, would you like me to add them to every single key instead of the few that had them prior?

@CLAassistant
Copy link

CLAassistant commented Mar 12, 2025

CLA assistant check
All committers have signed the CLA.

@KernelDeimos
Copy link
Contributor

Thanks for your contribution! @jelveh will review this soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants