dev: moved current datetime to toolbar as a widget #1172
Merged
+26
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KernelDeimos @jelveh - here's the initial PR for the proposed enhancement under #1171 |
|
Thanks, this implementation is very straightforward. No comments, I'm merging it now. |
|
Shesh , thanks @KernelDeimos ! |
|
This PR introduced unexpected movement of other icons on the upper bar when the clock is visible. It was a simple fix so I fixed that on main. Here's the commit if you'd like to review it: 8edcf75 |
|
@KernelDeimos - apologies, missed that. Thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the initial implementation for #1171.
ChangeLog
UIDesktopwith other toolbar buttonsdisplay_ct()underUIDesktophas been tweaked to display a better/sleek datetimestampwindow.change_clock_visibleintialization on DOM load has been moved toUIDesktopdue to DOM element accessibility bugNew Toolbar Clock UI:
Puter Desktop View:
