Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification management #1189

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

RadoBoiii
Copy link

Fixed the notification management system with a load more button to load additional notifications

  • Added notification history sidebar to display past notifications
  • Implemented pagination with "Load more" button
  • Added infinite scroll support for seamless loading
  • Fixed UI state inconsistencies
  • Added proper error handling
  • Improved mobile responsiveness

@CLAassistant
Copy link

CLAassistant commented Mar 17, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ sbeeredd04
✅ RadoBoiii
❌ Rishabh Shinde


Rishabh Shinde seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@RadoBoiii RadoBoiii closed this Mar 17, 2025
@RadoBoiii
Copy link
Author

Resolving conflicts in the pull requests

@RadoBoiii RadoBoiii reopened this Mar 17, 2025
Copy link
Contributor

@KernelDeimos KernelDeimos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of package-lock.json changes that don't seem relevant to this PR. They should be removed. If package-lock.json files are out of sync this should be addressed in a separate PR.

There are attempts to communicate with the database from client-side in this PR. That will never work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this modified? This seems out-of-scope for this PR. If this package-lock.json is out of sync we should update it but in a different PR.

@@ -883,4 +883,4 @@ class AIChatService extends BaseService {
}
}

module.exports = { AIChatService };
module.exports = { AIChatService };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text files should end with a line feed (LF) character so append operations behave as expected

@@ -1,5 +1,4 @@
// METADATA // {"ai-commented":{"service":"mistral","model":"mistral-large-latest"}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this comment removed? We have a tool that's able to generate automated comments (it's experimental; it's not very reliable but we might do more work on it later) and this metadata comment tells the tool if the file has already been commented on. We might use this same format for storing other metadata for source files in the future.


async function UIDesktop(options){
let h = '';

// Set up the desktop channel for communication between different tabs in the same browser
window.channel = new BroadcastChannel('puter-desktop-channel');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it verified that this former-global wasn't being referenced anywhere else?

var x1= day + ", " + month + " " + dt;
x1 = hours + ":" + minutes + ampm + " " + x1;
var x1=month + "/" + dt + "/" + x.getFullYear();
x1 = x1 + " - " + hours + ":" + minutes + ":" + seconds + " " + ampm;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we making changes to the clock here?


$(document).on('click', '.notification', function() {
// Update badge after notification is clicked
setTimeout(window.update_notification_badge_count, 100);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we polling so frequently here? If I merged this as-is, I wouldn't be surprised if it had a noticeable impact on puter.com. We get notifications over websockets, so we can usually update the count there; this should then be a very infrequent poll (several minutes) just in case the badge goes out of sync.

}

const db = await open({
filename: window.dbPath || './puter-database.sqlite',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ngl this scared the crap out of me because I thought maybe this is working. After a lot of manual testing I can confirm that this does not work. Not only does this not work, but this won't and should not ever work. If you ever do this and it works it means there's a severe security issue in the project your contributing to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants