Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to collapse tickets, and add a setting to auto-collapse a given ticket upon page load #254

Merged
merged 7 commits into from
Oct 16, 2024

Conversation

grablair
Copy link
Contributor

The use case here is for events with large numbers of tiered tickets. In my case, I have an event with 11 tiered tickets, each with 3+ tiers, and each tiered ticket corresponds to a given day.

In this case, the page is very long/noisy, and hard to navigate. Auto-collapsing the tickets so that the user only sees all the dates, initially, should help increase user-friendliness for these types of events.

I think it may be worth considering auto-collapsing all tickets by default if there are more than a certain amount of tickets on the page. This change does not do that, though; all tickets are not collapsed by default.

Screenshot 2024-10-14 at 15 44 01
Screenshot 2024-10-14 at 15 44 24

Checklist

  • I have read the contributing guidelines.
  • My code is of good quality and follows the coding standards of the project.
  • I have tested my changes, and they work as expected.

Thank you for your contribution! 🎉

@grablair
Copy link
Contributor Author

Added logic to make remaining ticket count work w/ the collapse arrow:

Screenshot 2024-10-14 at 16 01 52

@daveearley
Copy link
Contributor

I like this! Thanks for adding it. I'll set aside some time to test it soon.

@grablair
Copy link
Contributor Author

Screenshot 2024-10-15 at 08 38 44

Changed the "closed" arrow to a right-facing arrow, implying that when you click on it, there will be a next step.

@daveearley
Copy link
Contributor

Tested and working great. Thanks again @grablair. Very much appreciated!

@daveearley daveearley merged commit 4b0ba57 into HiEventsDev:develop Oct 16, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants