Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the timeout if no creds is available of specified. #249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove the timeout if no creds is available of specified. #249

wants to merge 1 commit into from

Conversation

jonathandumaresq
Copy link

This PR if useful when no credentials is known.

To test it: Do a flash erease on the ESP and reprogram the board, the AP come up quick.

@Hieromon
Copy link
Owner

@jonathandumaresq Thank you for the PR.
Your PR is very rational in some situations and useful for most users. It shouldn't be a problem with the natural use of AutoConnect.
However, I suspect that some users expect the reuse of the previous connection configuration data stored only on the SDK. That is, they specify AutoConnectConfig::autoSave=AC_SAVECREDENTIAL_NEVER. Your PR may not match this option well.
Do you have any other suggestions?

Hieromon added a commit that referenced this pull request Nov 3, 2020
@Hieromon
Improve WiFi.begin timeout with no creds #249
964fa8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathandumaresq @Hieromon