Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recovering from interrupted setup #73

Open
phoddie opened this issue Nov 21, 2022 · 0 comments
Open

recovering from interrupted setup #73

phoddie opened this issue Nov 21, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@phoddie
Copy link
Contributor

phoddie commented Nov 21, 2022

Installing can be interrupted, so xs-dev should recover gracefully to avoid leaving the installation in a bad state. Installs are even somewhat likely to be interrupted because some of them take a while to execute (lots to download, for example).

I experimented with this on macOS by hitting Control-C to interrupt the Moddable SDK and ESP8266 setup. If the Moddable SDK setup is interrupted, it seems to always leave behind a /moddable directory. which is enough to cause later attempt to xs-dev setup to fail to complete a real setup. The ESP8266 seems to recover better, but it does leave a partial installation.

For setup, maybe it is best to remove all the bits of the setup fails for some reason? That won't work for update though. I'm not sure what best practices are here.

The good news is that xs-dev teardown does get back to a safe state so setup can proceed again. But, that's only an option once the developer understands that they have a partial install that needs to be cleaned up before proceeding.

@HipsterBrown HipsterBrown added the enhancement New feature or request label Dec 1, 2022
andycarle added a commit to andycarle/xs-dev that referenced this issue Dec 21, 2022
Clones the Moddable SDK and builds tools in a temporary directory and then swaps to the permanent location when complete. One potential fix for HipsterBrown#73. (Windows only.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants