fix(setup): install to a temp directory and then swap (Windows) #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clones the Moddable SDK and builds tools in a temporary directory and then swaps to the permanent location when complete. One potential fix for HipsterBrown#73. (Windows only.)
HipsterBrown
requested changes
Dec 21, 2022
| } else { | ||
| try { | ||
| spinner.start('Cloning Moddable-OpenSource/moddable repo') | ||
| await system.spawn(`git clone ${MODDABLE_REPO} ${INSTALL_PATH}`) | ||
| await system.spawn(`git clone ${MODDABLE_REPO} ${MODDABLE_TEMP}`) |
There was a problem hiding this comment.
Maybe we could try getting the Windows setup to use the versioned release artifacts, like the Mac setup. At the very least, we should do a shallow clone to speed up this process: git clone --depth 1 --single-branch --branch public ${MODDABLE_REPO} ${MODDABLE_TEMP}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address the problem discussed in #73 on Windows. It does this by cloning the Moddable SDK into a temporary directory, building the Moddable SDK tools there, and then swapping the temp directory to the permanent location when complete.
If we like this approach, it could be applied to the other host platform tool setups, ESP32/ESP8266 setup, etc.