Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(info): verify moddable sdk git repo, include nrf52 support #160

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

HipsterBrown
Copy link
Owner

@HipsterBrown HipsterBrown commented Jan 19, 2024

Discovered by @mrpeu, the CLI assumes the directory for process.env.MODDABLE is a Git repository to be able to determine the Moddable SDK version or branch, as well as pull updates for the SDK. This PR adds an extra check to confirm it is a repo before attempting any git commands.

While working in the doctor command module, I noticed support for nrf52 was never added 😬 , so that has also been added in this PR.

xs-dev environment info:
  CLI Version                0.30.2
  OS                         Darwin
  Arch                       arm64
  Shell                      /bin/zsh
  NodeJS Version             v18.16.0 (/Users/nickhehr/.local/share/mise/installs/node/18.16.0/bin/node)
  Python Version             3.11.7 (/Users/nickhehr/.local/share/mise/installs/python/3.11/bin/python)
  Moddable SDK Version       4.3.4 (/Users/nickhehr/.local/share/moddable)
  Supported target devices   mac, pico, nrf52
  Pico SDK Directory         /Users/nickhehr/.local/share/pico/pico-sdk
  NRF52 SDK Directory        /Users/nickhehr/.local/share/nrf52/nRF5_SDK_17.0.2_d674dde

@HipsterBrown HipsterBrown merged commit 7302cd5 into main Jan 19, 2024
3 checks passed
@HipsterBrown HipsterBrown deleted the info-error-handling branch January 19, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant