Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made code Shellcheck complaint #85

Merged
merged 2 commits into from
Sep 5, 2021
Merged

Made code Shellcheck complaint #85

merged 2 commits into from
Sep 5, 2021

Conversation

mohitsaxenaknoldus
Copy link
Collaborator

Fixes #68

@mohitsaxenaknoldus mohitsaxenaknoldus mentioned this pull request Sep 4, 2021
Closed
2 tasks
@a-t-0
Copy link
Contributor

a-t-0 commented Sep 4, 2021

Awesome, I'll start reviewing this within 90 minutes!

a-t-0
a-t-0 requested changes Sep 4, 2021
View reviewed changes
Copy link
Contributor

@a-t-0 a-t-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marvellous work! If you could include two more changes, I would greatly appreciate it!

@mohitsaxenaknoldus
Copy link
Collaborator Author

@a-t-0 Check again please.

@a-t-0
Copy link
Contributor

a-t-0 commented Sep 5, 2021

Awesome! Thank you for your effort on improving this installation code!

@a-t-0 a-t-0 merged commit b6f8c70 into HiveMinds:issue-68-Clean_up_the_installation_code Sep 5, 2021
@mohitsaxenaknoldus mohitsaxenaknoldus deleted the issue68 branch September 5, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-t-0 a-t-0 a-t-0 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohitsaxenaknoldus @a-t-0