Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lesson 5 #3

Open
wants to merge 10 commits into
base: lesson-4
Choose a base branch
from
Open

Lesson 5 #3

wants to merge 10 commits into from

Commits on Nov 2, 2021

  1. refactors to viewModel class

    @gwbostee
    gwbostee committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    9302068 View commit details
    Browse the repository at this point in the history

  2. refactors current joke as liveData

    @gwbostee
    gwbostee committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    c5f454c View commit details
    Browse the repository at this point in the history

  3. refactors all logic to viewModel

    @gwbostee
    gwbostee committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    97134d1 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. adds viewModel with constructor for score view

    @gwbostee
    gwbostee committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    a2cf9d1 View commit details
    Browse the repository at this point in the history

  2. adds viewModel clickListeners to the XML - removing the Fragment as i… 

    …ntermediar
    @gwbostee
    gwbostee committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    7ee95e5 View commit details
    Browse the repository at this point in the history

  3. cleans up some leftovers

    @gwbostee
    gwbostee committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    bd8af8f View commit details
    Browse the repository at this point in the history

  4. fix final issue regarding viewModel construction

    @gwbostee
    gwbostee committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    e1256bb View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. adds viewmodel test

    @gwbostee
    gwbostee committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    1da58d3 View commit details
    Browse the repository at this point in the history

  2. adds test for livedata

    @gwbostee
    gwbostee committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    3306ae5 View commit details
    Browse the repository at this point in the history

  3. fix deprication

    @gwbostee
    gwbostee committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    4108e93 View commit details
    Browse the repository at this point in the history