Torus improvements, keeping Funext #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdchristensen
force-pushed
the
torus-with-funext
branch
from
b554472 to
721b78c
Compare
|
The changes here didn't significantly speed up TorusEquivCircle. It's still one of the slowest files in the library with one of the slowest lines. But it's not that bad, so isn't worth putting too much effort into. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the variant of PR #1824 that doesn't try to remove Funext, but still makes the other improvements plus a few additional changes. The commit titles are self-explanatory. You should deselect the indentation commit to see the real changes.