Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add atom cms and atom hk #17

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

dev-luizf
Copy link
Contributor

@dev-luizf dev-luizf commented Jan 15, 2024

This PR adds atom cms and hk to the project. It was based on @alanlomeli fork here, with some changes and fixes by me.

TO DO:

  • - Update readme with instructions on when run the new just commands

@Pi-Bouf
Copy link
Contributor

Pi-Bouf commented Jan 15, 2024

Hi @dev-luizf !

This MR is ready to review ? Or I need to wait the last TODO ?

(And thank you @alanlomeli)

@dev-luizf
Copy link
Contributor Author

Hi @dev-luizf !

This MR is ready to review ? Or I need to wait the last TODO ?

(And thank you @alanlomeli)

I think it would be better wait the last todo and one config about atom hk that I forgot. But the other PR is ready to review.

@dev-luizf
Copy link
Contributor Author

dev-luizf commented Jan 15, 2024

It is done @Pi-Bouf, you can review.

I'm not sure if atom submodules were added, because when a ran just install in a clean instalation they were not cloned, can you check it?

@dev-luizf
Copy link
Contributor Author

Any updates on this? @Pi-Bouf

@Pi-Bouf
Copy link
Contributor

Pi-Bouf commented Jan 28, 2024

Sorry @dev-luizf , I will take a look really soon !

Copy link
Contributor

@Pi-Bouf Pi-Bouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I tried, i've got some request:

  • please rebase with main
  • add your submodule folder, instead of that we can't have atom :(

@dev-luizf

@dev-luizf
Copy link
Contributor Author

dev-luizf commented Feb 5, 2024

OK I tried, i've got some request:

  • please rebase with main
  • add your submodule folder, instead of that we can't have atom :(

@dev-luizf

About the second point, you mean create atom and atom-hk folders?

I don't know much about git submodules

@Pi-Bouf
Copy link
Contributor

Pi-Bouf commented Feb 5, 2024

OK I tried, i've got some request:

  • please rebase with main
  • add your submodule folder, instead of that we can't have atom :(

@dev-luizf

About the second point, you mean create atom and atom-hk folders?

I don't know much about git submodules

Yes, when you setup a submodule you got two things: an entry inside the .gitmodules and a folder referencing the cloned module / the target and which branch to use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants