Ensure that the gh formula is sufficiently new

Homebrew · Jul 17, 2024 · 6db608f · 6db608f
1 parent 8839ccf
commit 6db608f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/Library/Homebrew/attestation.rb b/Library/Homebrew/attestation.rb
@@ -74,6 +74,10 @@ def self.gh_executable
         gh_version = Version.new(system_command!(@gh_executable, args: ["--version"], print_stderr: false)
                                  .stdout.match(/\d+(?:\.\d+)+/i).to_s)
         if gh_version < GH_ATTESTATION_MIN_VERSION
+          if Formula["gh"].version < GH_ATTESTATION_MIN_VERSION
+            raise "#{@gh_executable} is too old, you must upgrade it to >=#{GH_ATTESTATION_MIN_VERSION} to continue"
+          end
+
           @gh_executable = ensure_formula_installed!("gh", latest: true,
                                                            reason: "verifying attestations").opt_bin/"gh"
         end

diff --git a/Library/Homebrew/test/attestation_spec.rb b/Library/Homebrew/test/attestation_spec.rb
@@ -70,6 +70,10 @@
 
   describe "::gh_executable" do
     before do
+      allow(Formulary).to receive(:factory)
+        .with("gh")
+        .and_return(instance_double(Formula, version: Version.new("2.49.0")))
+
       allow(described_class).to receive(:system_command!)
         .with(fake_old_gh, args: ["--version"], print_stderr: false)
         .and_return(fake_old_gh_version)