Skip to content

Commit

Permalink
Port Homebrew::Cmd::Leaves
Browse files Browse the repository at this point in the history
  • Loading branch information
dduugg committed Mar 30, 2024
1 parent 0fd082a commit 8ab9d2c
Show file tree
Hide file tree
Showing 3 changed files with 42 additions and 43 deletions.
2 changes: 1 addition & 1 deletion Library/Homebrew/abstract_command.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ module Homebrew
# - Each Command lives in an isolated namespace.
# - Each Command implements a defined interface.
# - `args` is available as an ivar, and thus does not need to be passed as an argument to helper methods.
# - Subclasses no longer need to reference CLI::Parser directly.
# - Subclasses no longer need to reference `CLI::Parser` or parse args explicitly.
#
# To subclass, implement a `run` method and provide a `cmd_args` block to document the command and its allowed args.
# To generate method signatures for command args, run `brew typecheck --update`.
Expand Down
80 changes: 39 additions & 41 deletions Library/Homebrew/cmd/leaves.rb
Original file line number Diff line number Diff line change
@@ -1,51 +1,49 @@
# typed: true
# frozen_string_literal: true

require "abstract_command"
require "formula"
require "cask_dependent"
require "cli/parser"

module Homebrew
module_function

sig { returns(CLI::Parser) }
def leaves_args
Homebrew::CLI::Parser.new do
description <<~EOS
List installed formulae that are not dependencies of another installed formula or cask.
EOS
switch "-r", "--installed-on-request",
description: "Only list leaves that were manually installed."
switch "-p", "--installed-as-dependency",
description: "Only list leaves that were installed as dependencies."

conflicts "--installed-on-request", "--installed-as-dependency"

named_args :none
module Cmd
class Leaves < AbstractCommand
cmd_args do
description <<~EOS
List installed formulae that are not dependencies of another installed formula or cask.
EOS
switch "-r", "--installed-on-request",
description: "Only list leaves that were manually installed."
switch "-p", "--installed-as-dependency",
description: "Only list leaves that were installed as dependencies."

conflicts "--installed-on-request", "--installed-as-dependency"

named_args :none
end

sig { override.void }
def run
leaves_list = Formula.installed - Formula.installed.flat_map(&:runtime_formula_dependencies)
casks_runtime_dependencies = Cask::Caskroom.casks.flat_map do |cask|
CaskDependent.new(cask).runtime_dependencies.map(&:to_formula)

Check warning on line 29 in Library/Homebrew/cmd/leaves.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/cmd/leaves.rb#L29

Added line #L29 was not covered by tests
end
leaves_list -= casks_runtime_dependencies
leaves_list.select!(&method(:installed_on_request?)) if args.installed_on_request?
leaves_list.select!(&method(:installed_as_dependency?)) if args.installed_as_dependency?

leaves_list.map(&:full_name)
.sort
.each(&method(:puts))
end

def installed_on_request?(formula)
Tab.for_keg(formula.any_installed_keg).installed_on_request

Check warning on line 41 in Library/Homebrew/cmd/leaves.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/cmd/leaves.rb#L41

Added line #L41 was not covered by tests
end

def installed_as_dependency?(formula)
Tab.for_keg(formula.any_installed_keg).installed_as_dependency

Check warning on line 45 in Library/Homebrew/cmd/leaves.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/cmd/leaves.rb#L45

Added line #L45 was not covered by tests
end
end
end

def installed_on_request?(formula)
Tab.for_keg(formula.any_installed_keg).installed_on_request
end

def installed_as_dependency?(formula)
Tab.for_keg(formula.any_installed_keg).installed_as_dependency
end

def leaves
args = leaves_args.parse

leaves_list = Formula.installed - Formula.installed.flat_map(&:runtime_formula_dependencies)
casks_runtime_dependencies = Cask::Caskroom.casks.flat_map do |cask|
CaskDependent.new(cask).runtime_dependencies.map(&:to_formula)
end
leaves_list -= casks_runtime_dependencies
leaves_list.select!(&method(:installed_on_request?)) if args.installed_on_request?
leaves_list.select!(&method(:installed_as_dependency?)) if args.installed_as_dependency?

leaves_list.map(&:full_name)
.sort
.each(&method(:puts))
end
end
3 changes: 2 additions & 1 deletion Library/Homebrew/test/cmd/leaves_spec.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# frozen_string_literal: true

require "cmd/leaves"
require "cmd/shared_examples/args_parse"

RSpec.describe "brew leaves" do
RSpec.describe Homebrew::Cmd::Leaves do
it_behaves_like "parseable arguments"

context "when there are no installed Formulae", :integration_test do
Expand Down

0 comments on commit 8ab9d2c

Please sign in to comment.