-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-cmd/generate-cask-api: start generating cask internal JSON v3 #16798
Conversation
Before:
After:
|
c8e9bac
to
df2397c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few non-blocking thoughts/comments.
c6c5fcd
to
b5c9651
Compare
I'll merge this in tomorrow after I finish testing some things to make doubly sure that I'm not breaking current API JSON generation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks for making those changes ❤️
This adds a new file to the output of `brew generate-cask-api` which represents the new internal JSON v3 file. It involves removing a bunch of unneeded hash keys while removing blank ones as well. I've made some slight changes to the cask loader as well but more might be necessary before this starts loading things correctly. The full loader code will be added in a separate PR.
Waiting on discussion in #16826 (comment) Edit: It seems like that field isn't necessary. |
b5c9651
to
e0cea90
Compare
This is now getting generated by the main brew repo after my PR got merged in and this PR is a follow-up to make sure to sign it. The next step after this will be to build out the loader code. - Homebrew/brew#16798
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Part of #16410
This adds a new file to the output of
brew generate-cask-api
which represents the new internal JSON v3 file. It involves removing a bunch of unneeded hash keys while removing blank ones as well.I've made some slight changes to the cask loader as well but more might be necessary before this starts loading things correctly. The full loader code will be added in a separate PR.
Changes
Skippable hash fields
Nilable hash fields
New hash fields
Updated cask loader
Post Merge