Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements for brew command #17186

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

MikeMcQuaid
Copy link
Member

  • Add a (large) speedup by moving some logic to Bash for the typical case of a normal or dev-cmd, Bash or Ruby command.
  • Make brew command a non-developer command, I don't think it makes sense to consider it something needed for developing Homebrew.
  • Update the manpage accordingly.

Library/Homebrew/brew.sh Show resolved Hide resolved
Library/Homebrew/command_path.sh Outdated Show resolved Hide resolved
Library/Homebrew/command_path.sh Show resolved Hide resolved
- Add a (large) speedup by moving some logic to Bash for the typical
  case of a normal or dev-cmd, Bash or Ruby command.
- Make `brew command` a non-developer command, I don't think it makes
  sense to consider it something needed for developing Homebrew.
- Update the manpage/tests/RBI accordingly.

Co-authored-by: Carlo Cabrera <[email protected]>
@MikeMcQuaid MikeMcQuaid force-pushed the command_command_optimisation branch from 83c70c9 to 4ffcd8a Compare April 30, 2024 10:38
@MikeMcQuaid MikeMcQuaid merged commit 45e0ce0 into master Apr 30, 2024
26 checks passed
@MikeMcQuaid MikeMcQuaid deleted the command_command_optimisation branch April 30, 2024 10:48
@github-actions github-actions bot added the outdated PR was locked due to age label May 31, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants