dev-cmd/typecheck: Stop dry running Spoom sigil bumps #17621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sixteen months ago in PR 14921, I made it so that CI ran `brew typecheck --update --suggest-typed` and could commit the changes. - Except it never actually ever made any changes because of the `--dry` option in the Spoom CLI args. Whoops!
|
Oh, heh, even when it does change files it still exits 1 so Actions thinks the step has failed. |
- Annoyingly `spoom srb bump` exits with a status code of 1 even if it has done work to bump files, so we need to continue so the next workflow step commits the changes.
Bo98
reviewed
Jul 3, 2024
MikeMcQuaid
reviewed
Jul 4, 2024
MikeMcQuaid
reviewed
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?brew typecheck --update --suggest-typedon schedule in CI #14921, I made it so that CI ranbrew typecheck --update --suggest-typedand could commit the changes.--dryoption in the Spoom CLI args. Whoops!