-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ShellCommand
module for shell command stubs
#17758
Conversation
038e3a1
to
8851752
Compare
8851752
to
5fc0fe2
Compare
class Repository < AbstractCommand | ||
include ShellCommand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZhongRuoyu What's the thoughts on why include ShellCommand
was a better fit here than class Repository < ShellCommand
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't checked but the command system might detect ShellCommand as a command itself if it's a subclass of AbstractCommand.
Nice work here, thanks @ZhongRuoyu! I think a nice follow-up would be to rip out all the |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Follow-up to #17742, implementing @Bo98's idea #17742 (comment). A RuboCop has also been added to make sure each stub has its counterpart.