Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tap command: add -f alias to --force flag #18985

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Conversation

rrotter
Copy link
Contributor

@rrotter rrotter commented Dec 22, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Make brew tap -f == brew tap --force.

  • Current behavior is to reject -f with Error: ambiguous option: -f, however the only conflict is the disabled --full flag.
  • Improve consistency: tap is the only command with a --force option that isn't explicitly aliased w/ -f (see: git grep 'switch.*"--force"' Library/Homebrew)

Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks @rrotter!

@p-linnane p-linnane added this pull request to the merge queue Dec 22, 2024
Merged via the queue into Homebrew:master with commit 7d31007 Dec 22, 2024
28 checks passed
@rrotter rrotter deleted the force_tap branch December 23, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants