Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for 'brew list --version [--cask]'. #18999

Closed
wants to merge 3 commits into from

Conversation

ascherer
Copy link
Contributor

@ascherer ascherer commented Dec 24, 2024

Following my recent PR (#18996), I would like to amend test/cmd/list_spec.rb with some test cases to check that the output is alphabetically sorted.

HELP WANTED! How can I create temporary test packages in the Caskroom/ instead of in the Cellar/? Apart from HOMEBREW_PREFIX/Caskroom/, I've also learned about Cask::Caskroom.path. However, brew list [--cask] --version can't find the git cask either way.

I can only run 'brew tests' on Linux at this time, because my Mac Mini (macOS 14.7.2) fails due to missing file <mutex> (in mutex.cc).

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@ascherer ascherer force-pushed the test-list--cask--version branch 4 times, most recently from 9de6a1c to 9f09d39 Compare December 25, 2024 09:46
HELP WANTED! How can I create test packages in the 'Caskroom'?

I can only run 'brew tests' on Linux, because my Mac Mini (macOS 14.7.2)
fails due to missing "mutex.h" (or some such).

At least the new test for 'brew list --version' succeeds (on Linux).

Squashed commits to (partial) success:
Try 'brew style list_spec.rb'.
Try 'rubocop -a'.
Generic OS fails.
Generic OS fails again.
The 'Caskroom' is not yet populated.
'brew list --cask' seems to work, but both 'brew list --cask --version'
and 'brew list --version' fail because of empty cask list.
@ascherer ascherer force-pushed the test-list--cask--version branch from 9f09d39 to 2f3806a Compare December 26, 2024 19:07
@ascherer ascherer closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants