Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify accepted syntax in brew.env files in Homebrew docs #19013

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pa-0
Copy link

@pa-0 pa-0 commented Dec 28, 2024

Added some clarification on what is and is not supported in brew.env files, i.e., they do NOT support export commands.

Based on discussion here: https://github.com/orgs/Homebrew/discussions/5232#discussioncomment-8919542 (where improvements to docs suggested/welcomed)

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

pa-0 added 2 commits December 28, 2024 13:32
Added some clarification on what is and is not supported in brew.env files.. (They are not shell scripts, and do NOT support export commands)

Based on discussion here: https://github.com/orgs/Homebrew/discussions/5232#discussioncomment-8919542
(where improvements to docs suggested/welcomed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant