Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_environment: pass http_proxy env vars through to build env #19093

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

gibfahn
Copy link
Contributor

@gibfahn gibfahn commented Jan 13, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This allows you to build bottles in an environment that doesn't have
access to the source URLs, or things downloaded during the bottling
phase, without a proxy.

These are the set of environment variables that are already documented
in man brew.

This allows you to build bottles in an environment that doesn't have
access to the source URLs, or things downloaded during the bottling
phase, without a proxy.

These are the set of environment variables that are already documented
in `man brew`.
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks again @gibfahn!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jan 14, 2025
Merged via the queue into Homebrew:master with commit f16f699 Jan 14, 2025
28 checks passed
@gibfahn gibfahn deleted the proxy_build branch January 14, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants