-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fish shell completions to brew #6217
Add fish shell completions to brew #6217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Copy fish completions from github.com/laughdelic/brew-completions
This URL doesn't work; can you confirm the source and if the license permits this?
Otherwise: looks good 👍
The correct URL should be https://github.com/laughedelic/brew-completions/. The license is GPLv3 so I don't think we can just merge this. |
@laughedelic can you confirm you are happy for your code to be included in this repository under these terms: https://github.com/Homebrew/brew/blob/master/LICENSE.txt? |
@MikeMcQuaid: I corrected the URL in the PR description now. :) |
Thank you @lwolfsonkin for pushing this forward and taking extra effort for the improvements! 👏 I'm fine with the BSD license, but I would appreciate being mentioned as a co-author in the merge commit if this is fine with you:
|
Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @lwolfsonkin!
Done, thanks for your initial work on this too @laughedelic: you also rock! |
Closes #6172
brew pin
suggest only unpinned formulaebrew search
's cachedesc_cache.json
brew cask cleanup
brew style
with your changes locally?brew tests
with your changes locally?