Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[email protected]: promote to default python3 #150390

Merged
merged 5 commits into from
Feb 21, 2024
Merged

[email protected]: promote to default python3 #150390

merged 5 commits into from
Feb 21, 2024

Conversation

branchvincent
Copy link
Member

@branchvincent branchvincent commented Oct 10, 2023 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Hopefully this is a smoother transition than last year since all formulae should now be using fully-qualified python binaries like python3.11

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 10, 2023
@branchvincent branchvincent added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Oct 10, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Oct 10, 2023
@p-linnane p-linnane added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing labels Oct 10, 2023
@p-linnane p-linnane requested a review from Bo98 October 11, 2023 03:25
@branchvincent
Copy link
Member Author

branchvincent commented Oct 11, 2023 •
edited
Loading

So far without Linux

@branchvincent branchvincent mentioned this pull request Oct 11, 2023
Closed
6 tasks
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Oct 11, 2023
@Bo98
Copy link
Member

Bo98 commented Oct 11, 2023

Might be worth revision bumping so the user doesn't end up in a scenario where they have Python 3.12 already installed but no python3.

Bo98
Bo98 reviewed Oct 11, 2023
View reviewed changes
Formula/p/[email protected] Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Nov 7, 2023
@branchvincent branchvincent removed the stale No recent activity label Nov 9, 2023
@onlined
Copy link
Contributor

onlined commented Nov 28, 2023

What is blocking this PR right now? I can lend a hand.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Dec 19, 2023
@nickserv
Copy link

This appears to still be good.

@github-actions github-actions bot removed the stale No recent activity label Dec 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Jan 11, 2024
@nickserv
Copy link

This appears to still be good. I'm still not sure why we wouldn't want to migrate to the newest version, especially considering the typing improvements.

@github-actions github-actions bot removed the stale No recent activity label Jan 13, 2024
SMillerDev
SMillerDev requested changes Jan 13, 2024
View reviewed changes
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting #150390 (comment)

@cho-m
Copy link
Member

cho-m commented Jan 15, 2024

Awaiting #150390 (comment)

Which may also depend on #157500 if we decide to drop majority of python-* formulae.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Feb 6, 2024
cho-m
cho-m reviewed Feb 20, 2024
View reviewed changes
Formula/p/[email protected]
Comment on lines -474 to -475
tkinter is no longer included with this formula, but it is available separately:
brew install python-tk@#{version.major_minor}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we want to remove this caveat? There is also the python-gdbm caveat in [email protected] that didn't carry over to [email protected].

[email protected] and [email protected] will remain as they are part of base Python but we just put them into separate formulae (given that Homebrew doesn't support sub/split-packages).

Not important to handle here but may want to add caveats in follow up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it makes sense to handle this in a followup syntax PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed that line because it now felt useless. We had it for a few years now I think. I hope our users have adjusted their workflows, and my hope was to stop telling obvious things in the caveats.
But if you think we need to add it back: this can be done in a syntax-only follow-up pull request.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't matter to me whether we keep or remove it.

Homebrew's way of separate formulae is a bit odd since we don't support sub/split-packages. Most repositories would either install everything together (e.g. Arch Linux) or use subpackages (which colocates the related packages that use the same source distribution).

@p-linnane p-linnane removed automerge-skip `brew pr-automerge` will skip this pull request in progress Stale bot should stay away CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Feb 20, 2024
@github-actions github-actions bot added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Feb 20, 2024
@branchvincent branchvincent mentioned this pull request Feb 21, 2024
Merged
@cho-m
Copy link
Member

cho-m commented Feb 21, 2024

Failures that can be followed up on:

  • libcap-ng is probably installing Python bindings into $HOMEBREW_PREFIX/lib/... rather than #{lib}/... since we don't have a sandbox on Linux. This means it passes when built from source but will fail later on when installed from bottle.
  • profanity is building with python3-embed so Python feature is disabled on macOS and linked to [email protected] on Linux. May be worth adding a major-versioned symlink to libexec so we can use PKG_CONFIG_PATH rather than an inreplace workaround (or manually passing in corresponding python_CFLAGS/python_LIBS).

@github-actions GitHub Actions
Copy link
Contributor

:shipit: @branchvincent has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Feb 21, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 21, 2024
Merged via the queue into Homebrew:master with commit 0cefaa8 Feb 21, 2024
12 checks passed
@branchvincent branchvincent deleted the python3.12 branch February 21, 2024 17:14
@cho-m cho-m mentioned this pull request Feb 21, 2024
Merged
6 tasks
@p-linnane
Copy link
Member

Thanks for all the work here @branchvincent!

@jwnimmer-tri jwnimmer-tri mentioned this pull request Feb 21, 2024
Closed
7 tasks
@branchvincent
Copy link
Member Author

And thanks @iMichka for all the doc updates!

@scpeters scpeters mentioned this pull request Feb 23, 2024
Closed
9 tasks
chenrui333 added a commit to chenrui333/github-action-test that referenced this pull request Mar 8, 2024
@chenrui333
brew-debug(macos): remove py3.12 linkage fix
cc1f883 
relates to Homebrew/homebrew-core#150390

Signed-off-by: Rui Chen <[email protected]>
@hebasto hebasto mentioned this pull request Mar 10, 2024
Merged
fanquake added a commit to bitcoin/bitcoin that referenced this pull request Mar 12, 2024
@fanquake
Merge #29610: ci: Fix "macOS native" job
bd55b7a 
acc06bc ci, macos: Use `--break-system-packages` with Homebrew's python (Hennadii Stepanov)
ae5f720 ci: Add workaround for Homebrew's python link error (Hennadii Stepanov)

Pull request description:

  Homebrew [promoted](Homebrew/homebrew-core#150390) `[email protected]` to the default `python3`. Now, our "macOS native" CI job is facing the following issues:

  1. Installing `qt@5` [requires](https://github.com/bitcoin/bitcoin/actions/runs/8216848118/job/22471875454#step:4:51) re-installing `[email protected]`:
  ```
  ==> Fetching dependencies for qt@5: readline, [email protected] and gettext
  ```
  2. Re-installing `[email protected]` [fails](https://github.com/bitcoin/bitcoin/actions/runs/8216848118/job/22471875454#step:4:127) due to symbolic link conflicts on macOS `x86_64`:
  ```
  ==> Pouring [email protected]_1.ventura.bottle.tar.gz
  Error: The `brew link` step did not complete successfully
  ```
  3. Homebrew's `[email protected]` is marked as externally managed (according to PEP 668), necessitating different approaches for installing Python packages.

  This pull request resolves all the issues mentioned above.

ACKs for top commit:
  m3dwards:
    reACK acc06bc to get the CI passing again.

Tree-SHA512: 82cf72bff328f1e0725342431ac14ad4bae7a758186d97db6c7a558e4b661dcbf3fabe536978e26e709c5f6f7f5c11aac46642634c6685f1291592d8d825ad87
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cho-m cho-m cho-m left review comments

@iMichka iMichka iMichka approved these changes

@p-linnane p-linnane p-linnane approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@SMillerDev SMillerDev SMillerDev approved these changes

@Bo98 Bo98 Awaiting requested review from Bo98

Assignees
No one assigned
Labels
CI-linux-self-hosted Build on Linux self-hosted runner CI-no-bottle-cache Disable bottle cache CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Set a long timeout for formula testing outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.