Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjazz 20231028 #152682

Closed
wants to merge 11 commits into from
Closed

openjazz 20231028 #152682

wants to merge 11 commits into from

Conversation

Kreeblah
Copy link
Contributor

Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.
release notes 
🎃  Halloween Release 👻 

Changes:


    

  • TBD
    • 



The Windows builds are powered by MinGW and MXE (http://mxe.cc/).

The source tarball is intended for use under UNIX-like environments (powered by cmake).

@github-actions github-actions bot added deprecated license Formula uses a deprecated SPDX license which should be updated bump-formula-pr PR was created using `brew bump-formula-pr` labels Oct 28, 2023
@p-linnane
Copy link
Member

Looks like this has switched to building with CMake now.

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 29, 2023
SMillerDev
SMillerDev reviewed Oct 29, 2023
View reviewed changes
Formula/o/openjazz.rb Outdated Show resolved Hide resolved
@Kreeblah
Copy link
Contributor Author

So, I've been looking at this since I submitted the original PR and it failed to build. I also haven't been able to get it to build locally with CMake, even outside of Homebrew. I think there might be some issues upstream that need to be resolved before this can be updated.

@SMillerDev
Copy link
Member 

   In file included from /tmp/openjazz-20231029-4131-wyfo4h/openjazz-20231028/ext/psmplug/fastmix.cpp:8:
  /tmp/openjazz-20231029-4131-wyfo4h/openjazz-20231028/ext/psmplug/stdafx.h:49:10: fatal error: 'malloc.h' file not found
  #include <malloc.h>
           ^~~~~~~~~~

@github-actions github-actions bot removed the deprecated license Formula uses a deprecated SPDX license which should be updated label Oct 29, 2023
@Kreeblah
Copy link
Contributor Author

Yep, that's what I keep running into. It's trying to include malloc.h.

SMillerDev
SMillerDev reviewed Oct 29, 2023
View reviewed changes
Formula/o/openjazz.rb Outdated Show resolved Hide resolved
@SMillerDev SMillerDev mentioned this pull request Oct 29, 2023
Closed
@SMillerDev
Copy link
Member

Builds fine now

@Kreeblah @SMillerDev
Update Formula/o/openjazz.rb
252bb86 
Co-authored-by: Sean Molenaar <[email protected]>
@Kreeblah
Copy link
Contributor Author

They did also update to SDL2 with this release. That builds fine locally for me with these changes, so I'll try updating the dependencies.

SMillerDev
SMillerDev previously approved these changes Oct 29, 2023
View reviewed changes
@carstene1ns
Copy link

Will merge upstream PR in a bit, should not be needed in next release...
Thanks for maintaining :)

carstene1ns
carstene1ns reviewed Oct 29, 2023
View reviewed changes
Formula/o/openjazz.rb Outdated Show resolved Hide resolved
Formula/o/openjazz.rb Show resolved Hide resolved
chenrui333
chenrui333 previously approved these changes Oct 30, 2023
View reviewed changes
@Kreeblah
Copy link
Contributor Author

That last commit (the DATAPATH one) adds the last suggestion from @carstene1ns (which sets the default game file search directory to where the caveats tell the user to put the game files), so I think this is good to go now.

SMillerDev
SMillerDev previously approved these changes Oct 30, 2023
View reviewed changes
@github-actions
Copy link
Contributor

🤖 An automated task has requested creation of a replacement PR.

@github-actions github-actions bot dismissed stale reviews from SMillerDev, SMillerDev, and chenrui333 October 31, 2023 06:28

Replacement PR dispatched

BrewTestBot pushed a commit that referenced this pull request Oct 31, 2023
@Kreeblah @SMillerDev @BrewTestBot
openjazz 20231028
89c0747 
* openjazz 20231028
* openjazz: use cmake and clean up formula
* openjazz: fix style
* Update license
* openjazz: remove malloc usage
* openjazz: do not recreate binary
* Update license
* Update Formula/o/openjazz.rb
* Update to SDL2
* Remove unneeded dependencies
* Add DATAPATH to point to pkgshare

Closes #152682.

Co-authored-by: Sean Molenaar <[email protected]>
Signed-off-by: BrewTestBot <[email protected]>
@BrewTestBot BrewTestBot mentioned this pull request Oct 31, 2023
Merged
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request superseded PR was replaced by another PR labels Oct 31, 2023
@BrewTestBot BrewTestBot marked this pull request as draft October 31, 2023 06:28
@github-actions
Copy link
Contributor

✅ Replacement PR created at #152900.

github-merge-queue bot pushed a commit that referenced this pull request Oct 31, 2023
@BrewTestBot
Merge pull request #152900 from Homebrew/PR/152682
74ff9d4 
Replacement for #152682
@Kreeblah Kreeblah deleted the bump-openjazz-20231028 branch October 31, 2023 06:49
@ZhongRuoyu ZhongRuoyu mentioned this pull request Nov 28, 2023
Closed
1 task
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carstene1ns carstene1ns carstene1ns left review comments

@SMillerDev SMillerDev SMillerDev left review comments

@chenrui333 chenrui333 chenrui333 left review comments

Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request autosquash Automatically squash pull request commits according to Homebrew style. bump-formula-pr PR was created using `brew bump-formula-pr` outdated PR was locked due to age superseded PR was replaced by another PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kreeblah @p-linnane @SMillerDev @carstene1ns @chenrui333