arjun: vendor python resources #162678
Merged
arjun: vendor python resources #162678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
automerge-skip
timsutton
commented
Feb 14, 2024
SMillerDev
approved these changes
Feb 14, 2024
p-linnane
reviewed
Feb 14, 2024
There was a problem hiding this comment.
Looks great! Let's drop the revision bump like @SMillerDev said, and also drop python-certifi and this will be good to go.
p-linnane
added
the
python-vendoring
timsutton
force-pushed
the
arjun-vendor-python
branch
from
4878eae to
631a430
Compare
timsutton
commented
Feb 14, 2024
| depends_on "python-setuptools" => :build | ||
| depends_on "python-dicttoxml" | ||
| depends_on "python-requests" | ||
| depends_on "python-certifi" |
There was a problem hiding this comment.
Keeping certifi as a separate dep based on #157500 (comment)
p-linnane
removed
the
automerge-skip
p-linnane
approved these changes
Feb 14, 2024
|
🤖 An automated task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Based on what I read in #157500, I picked a random Python formula to get a feel for how this would work.
But now actually, I see I'm effectively just reverting what @chenrui333 did in #155711 🤔 – so, I'm completely fine to hold off on a change like this (or in this particular formula), this was mostly just me trying an exercise.