Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watchman: use default state directory (TMPDIR). #173850

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions Formula/w/watchman.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
class Watchman < Formula

Check warning on line 1 in Formula/w/watchman.rb

View workflow job for this annotation

GitHub Actions / macOS 14-x86_64

`brew linkage --cached --test --strict watchman` failed on macOS Sonoma (14)!

Indirect dependencies with linkage: double-conversion fizz lz4 snappy wangle xz zstd

Check warning on line 1 in Formula/w/watchman.rb

View workflow job for this annotation

GitHub Actions / macOS 14-arm64

`brew linkage --cached --test --strict watchman` failed on macOS Sonoma (14) on Apple Silicon!

Indirect dependencies with linkage: double-conversion fizz lz4 snappy wangle xz zstd

Check warning on line 1 in Formula/w/watchman.rb

View workflow job for this annotation

GitHub Actions / macOS 13-x86_64

`brew linkage --cached --test --strict watchman` failed on macOS Ventura (13)!

Indirect dependencies with linkage: double-conversion fizz lz4 snappy wangle xz zstd

Check warning on line 1 in Formula/w/watchman.rb

View workflow job for this annotation

GitHub Actions / macOS 13-arm64

`brew linkage --cached --test --strict watchman` failed on macOS Ventura (13) on Apple Silicon!

Indirect dependencies with linkage: double-conversion fizz lz4 snappy wangle xz zstd

Check warning on line 1 in Formula/w/watchman.rb

View workflow job for this annotation

GitHub Actions / macOS 12-x86_64

`brew linkage --cached --test --strict watchman` failed on macOS Monterey (12)!

Indirect dependencies with linkage: double-conversion fizz lz4 snappy wangle xz zstd

Check warning on line 1 in Formula/w/watchman.rb

View workflow job for this annotation

GitHub Actions / macOS 12-arm64

`brew linkage --cached --test --strict watchman` failed on macOS Monterey (12) on Apple Silicon!

Indirect dependencies with linkage: double-conversion fizz lz4 snappy wangle xz zstd
desc "Watch files and take action when they change"
homepage "https://github.com/facebook/watchman"
url "https://github.com/facebook/watchman/archive/refs/tags/v2024.05.06.00.tar.gz"
Expand All @@ -16,9 +16,6 @@
sha256 cellar: :any_skip_relocation, x86_64_linux: "24919bbc7c971be7fe37ea161ea4268604c67dcfe6435dc2258b2050cb4495c3"
end

# https://github.com/facebook/watchman/issues/963
pour_bottle? only_if: :default_prefix

depends_on "cmake" => :build
depends_on "cpptoml" => :build
depends_on "edencommon" => :build
Expand Down Expand Up @@ -62,7 +59,7 @@
"-DPython3_EXECUTABLE=#{which("python3.12")}",
"-DWATCHMAN_VERSION_OVERRIDE=#{version}",
"-DWATCHMAN_BUILDINFO_OVERRIDE=#{tap.user}",
"-DWATCHMAN_STATE_DIR=#{var}/run/watchman",
"-DWATCHMAN_STATE_DIR=",
*std_cmake_args
system "cmake", "--build", "build"
system "cmake", "--install", "build"
Expand All @@ -73,11 +70,6 @@
path.rmtree
end

def post_install
(var/"run/watchman").mkpath
chmod 042777, var/"run/watchman"
end

test do
assert_equal(version.to_s, shell_output("#{bin}/watchman -v").chomp)
end
Expand Down
Loading