Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vitess: build with [email protected] #182757

Merged
merged 1 commit into from
Aug 28, 2024
Merged

vitess: build with [email protected] #182757

merged 1 commit into from
Aug 28, 2024

Conversation

stefanb
Copy link
Member

@stefanb stefanb commented Aug 28, 2024

use "go" again after vitessio/vitess#16015 is fixed and released

Follow-up to #175310

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

use "go" again after vitessio/vitess#16015 is fixed and released

Follow-up to #175310
@stefanb stefanb added the CI-no-bottles Merge without publishing bottles label Aug 28, 2024
@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Aug 28, 2024
@chenrui333 chenrui333 added this pull request to the merge queue Aug 28, 2024
Merged via the queue into master with commit 107d057 Aug 28, 2024
23 checks passed
@chenrui333 chenrui333 deleted the vitess-go1.22 branch August 28, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants