Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gorilla-cli: fix test #192048

Merged
merged 1 commit into from
Sep 27, 2024
Merged

gorilla-cli: fix test #192048

merged 1 commit into from
Sep 27, 2024

Conversation

branchvincent
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Short-term alternative to #188498 to keep our CI passing

Looks like the API at https://cli.gorilla-llm.com has an expired SSL cert, so this just expects a failure in the test. Alternatively, we could patch the HTTP requests with verify=False to skip SSL verification, which would keep the CLI functional but ofc less secure

@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Sep 26, 2024
@branchvincent branchvincent mentioned this pull request Sep 26, 2024
6 tasks
@branchvincent branchvincent added the CI-no-bottles Merge without publishing bottles label Sep 26, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 27, 2024
Merged via the queue into Homebrew:master with commit 40d5a46 Sep 27, 2024
23 checks passed
@branchvincent branchvincent deleted the gorilla-cli branch September 27, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants