workflows/scheduled: improve coverage of scheduled online checks #192485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
workflows
carlocab
force-pushed
the
systematic-schedule
branch
from
2e67df5
to
e7c8b17
Compare
MikeMcQuaid
approved these changes
Oct 1, 2024
carlocab
force-pushed
the
systematic-schedule
branch
from
e7c8b17
to
b197de5
Compare
Let's test our formulae more systematically. We do this by
indexing all formulae so that:
- formulae 1 to 50 are tested on the first day of the year
- formulae 51 to 100 are tested on the second day of the year
- formulae 101 to 150 are tested on the third day of the year
- and so on.
This works fine as long as we have fewer than 365 * TEST_COUNT formulae
(currently 18250).
While we're here:
- scope token permissions more tightly
- remove the `os` key from the matrix, since there is only one entry
- remove unused references to `macos-latest`
- always run the formula source test as long as the upstream repository
has not been archived
- remove the unnecessary `${{ }}` in `if:` properties
- error out with a comment posted if `create_matrix` fails
carlocab
force-pushed
the
systematic-schedule
branch
from
b197de5
to
e0da17f
Compare
carlocab
commented
Oct 1, 2024
This way we don't test all the various `postgresql@*` formulae on the same day.
carlocab
added
ready to merge
MikeMcQuaid
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's test our formulae more systematically. We do this by
indexing all formulae so that:
This works fine as long as we have fewer than 365 * TEST_COUNT formulae
(currently 18250).
While we're here:
oskey from the matrix, since there is only one entrymacos-latesthas not been archived
${{ }}inif:properties