Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libbsd: remove dependency on 'linux' #198648

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

bimimicah
Copy link
Contributor

@bimimicah bimimicah commented Nov 22, 2024

Update libbsd.rb - remove dependency on 'linux' now that upstream has macOS support

This is not the real PR, just a draft to see if it passes CI checks as suggested in
See discussion #5755 here.

Should resolve build issue in mod_authz_unixgroup

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 22, 2024
Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fails on macOS -- you can try this:

--- a/Formula/lib/libbsd.rb
+++ b/Formula/lib/libbsd.rb
@@ -26,6 +25,6 @@ class Libbsd < Formula
   end
 
   test do
-    assert_match "strtonum", shell_output("nm #{lib/"libbsd.so.#{version}"}")
+    assert_match "strtonum", shell_output("nm #{lib/shared_library("libbsd")}")
   end
 end

@bimimicah
Copy link
Contributor Author

Test fails on macOS -- you can try this:

+    assert_match "strtonum", shell_output("nm #{lib/shared_library("libbsd")}")

Thanks

Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@ZhongRuoyu ZhongRuoyu changed the title Update libbsd.rb - remove dependency on 'linux' now that upstream has macOS support libbsd: remove dependency on 'linux' Nov 22, 2024
Remove dependency on 'linux' now that upstream has macOS support
Updated tests provided by @ZhongRuoyu
@bimimicah bimimicah force-pushed the libbsd_mac_test_branch branch from f5170e4 to 30b0dfb Compare November 22, 2024 21:32
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 22, 2024
@bimimicah bimimicah marked this pull request as ready for review November 22, 2024 21:54
@bimimicah
Copy link
Contributor Author

Please let me know if there is anything else I should do to improve this, thanks for all your help!

Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @bimimicah!

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Copy link
Contributor

⚠️ Bottle publish failed.

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 22, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 22, 2024
Merged via the queue into Homebrew:master with commit b5068d4 Nov 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants