-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libbsd: remove dependency on 'linux' #198648
libbsd: remove dependency on 'linux' #198648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test fails on macOS -- you can try this:
--- a/Formula/lib/libbsd.rb
+++ b/Formula/lib/libbsd.rb
@@ -26,6 +25,6 @@ class Libbsd < Formula
end
test do
- assert_match "strtonum", shell_output("nm #{lib/"libbsd.so.#{version}"}")
+ assert_match "strtonum", shell_output("nm #{lib/shared_library("libbsd")}")
end
end
Thanks |
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
Remove dependency on 'linux' now that upstream has macOS support Updated tests provided by @ZhongRuoyu
f5170e4
to
30b0dfb
Compare
Please let me know if there is anything else I should do to improve this, thanks for all your help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you @bimimicah!
🤖 An automated task has requested bottles to be published to this PR. |
|
Update libbsd.rb - remove dependency on 'linux' now that upstream has macOS support
This is not the real PR, just a draft to see if it passes CI checks as suggested inSee discussion #5755 here.
Should resolve build issue in mod_authz_unixgroup
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?