malcontent: add caveats #201714
Closed
malcontent: add caveats #201714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
go
Signed-off-by: egibs <[email protected]>
egibs
force-pushed
the
add-malcontent-caveat
branch
from
d461d0c to
615b0ff
Compare
ZhongRuoyu
reviewed
Dec 19, 2024
Comment on lines
+25
to
+32
| def caveats | ||
| <<~EOS | ||
| malcontent embeds Yara rules in order to scan files and | ||
| certain AV or anti-malware software may detect malcontent as malicious. | ||
| Programs that leverage Yara will generally see other programs that also use Yara as malicious | ||
| due to their respective strings looking for problematic behavior. | ||
| EOS | ||
| end |
There was a problem hiding this comment.
Thanks for the PR @egibs! Caveats are generally for issues specifically related to Homebrew packaging 1, so judging from chainguard-dev/malcontent#727 this may not be a good fit?
Footnotes
There was a problem hiding this comment.
Totally fair! We’ll rely on that messaging instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?This PR adds a more visible disclaimer re: AV detections when installing/running malcontent.
For more context: chainguard-dev/malcontent#727