go 1.14.7 #59242

jnozsc · 2020-08-06T17:10:23Z

Created with brew bump-formula-pr.

jnozsc · 2020-08-07T14:57:34Z

test failure on macOS 10.15

Error: 10 failed steps!
brew install --build-from-source berglas
brew install --build-from-source charm
brew install --build-from-source cig
brew install --build-from-source dashing
brew test --retry --verbose dashing
brew install --build-from-source ship
brew install --build-from-source tektoncd-cli
brew install --build-from-source the_platinum_searcher
brew install --build-from-source wellington
brew install --build-from-source wskdeploy

test failure on macOS 10.14

Error: 11 failed steps!
brew install --build-from-source berglas
brew install --build-from-source charm
brew install --build-from-source cig
brew install --build-from-source dashing
brew test --retry --verbose dashing
brew install --build-from-source grv
brew install --build-from-source ship
brew install --build-from-source tektoncd-cli
brew install --build-from-source the_platinum_searcher
brew install --build-from-source wellington
brew install --build-from-source wskdeploy

test failure on macOS 10.13

Error: 10 failed steps!
brew install --build-from-source berglas
brew install --build-from-source charm
brew install --build-from-source cig
brew install --build-from-source dashing
brew test --retry --verbose dashing
brew install --build-from-source ship
brew install --build-from-source tektoncd-cli
brew install --build-from-source the_platinum_searcher
brew install --build-from-source wellington
brew install --build-from-source wskdeploy

These 3

charm
dashing
wellington

are covered in #56539

new issues

formula	issue	note	fix
berglas	checksum mismatch		#59297
cig	godep issue		fixed after revision bump in `godep`
grv	xcode issue	10.14 only, was introduced since #58115, similar issue #32533	still broken after revision bump in `godep`
ship	deps mess	was introduced since #58115	upstream fix replicatedhq/ship#1126 , homebrew fix #59302
tektoncd-cli	checksum mismatch		#59300
the_platinum_searcher	godep issue		fixed after revision bump in `godep`
wskdeploy	godep issue		fixed after revision bump in `godep`

jnozsc · 2020-08-07T22:57:46Z

do I still need to bump the revision in Formula/godep.rb ? The formula has been marked as deprecate! from #58115

chenrui333 · 2020-08-08T11:33:50Z

@jnozsc, another thing I just realized is if you checked the previous PRs, we should have two separate commits:

one for go, go 1.14.7
one for dep, godep: revision bump for go

But we can totally do it after fixing the stuff that we can fix.

jnozsc · 2020-08-08T12:38:57Z

@chenrui333
thanks.

That's exactly what I am still confused. in previous PR #58115 , godep had been marked as deprecate! , do we still need to maintain it?

SMillerDev · 2020-08-08T14:26:42Z

That's exactly what I am still confused. in previous PR #58115 , godep had been marked as deprecate! , do we still need to maintain it?

It's just deprecated. It isn't removed so people can and will still install it. And that install should be working correctly

jnozsc · 2020-08-08T14:27:51Z

ok, thanks for clarifying this

chenrui333 · 2020-08-08T16:09:28Z

cancelled the build for now, and we can have a final run after fixing the stuff that we can fix. And then merging this patch upgrade.

jnozsc · 2020-08-08T16:47:29Z

rebase from master. let's check whether these issues get fixed or not

chenrui333 · 2020-08-08T17:40:28Z

I am also inclined to do the merge and rebase to fix each formula (it is little bit costly to have golang runs)

jnozsc · 2020-08-10T00:48:14Z

the test on 10.15 takes too much time, let's focus on 10.14 and 10.13 first

tests fail on 10.14

Error: 6 failed steps!
brew install --build-from-source charm
brew install --build-from-source dashing
brew test --retry --verbose dashing
brew install --build-from-source grv
brew test --retry --verbose ssh-vault
brew install --build-from-source wellington

tests fails on 10.13

Error: 4 failed steps!
brew install --build-from-source charm
brew install --build-from-source dashing
brew test --retry --verbose dashing
brew install --build-from-source wellington

the revision bump on godep definitely fixes some issues

what we have now

formula	issue	note	fix	installation analytics (check on Aug 10th 2020)
charm	project is abandoned from upstream		tracked in homebrew #56539, upstream ticket juju/charmstore-client#209	23 installs (30 days)
dashing	test is broken		tracked in homebrew #56539, I create a PR to fix it #59391 . It gets merged	58 installs (30 days)
grv	xcode issue	10.14 only, was introduced since #58115, similar issue #32533	still broken after revision bump in godep, NEED HELP	40 installs (30 days)
ssh-vault	`key new not found` error	10.14 only, this issue does not happen last time when we bump `go` to 1.14.7	a flaky test?	34 installs (30 days)
wellington	project is abandoned from upstream		tracked in homebrew #56539, upstream ticket wellington/wellington#218	8 installs (30 days)

WZZ1998 · 2020-08-10T08:24:14Z

Emm... Have these formula been fixed?

jnozsc · 2020-08-10T15:47:43Z

the test on 10.15 is too longer than it should be, should we restart it? cc @chenrui333

chenrui333 · 2020-08-10T16:07:48Z

the test on 10.15 is too longer than it should be, should we restart it? cc @chenrui333

nope, unless there is something very wrong happening. We can also cross map how much time it should run before.

jnozsc · 2020-08-10T16:10:07Z

it took 13 hours on previous go PR. #58115

chenrui333 · 2020-08-10T16:11:42Z

Two days over the previous release is indeed too long (1d 23h 18m 37s vs 13h 9m 26s), cancelled the build

jnozsc · 2020-08-10T17:16:21Z

update the table above by adding a installation analytics column.

Due to the number of installation, I would like to suggest to rebase from master again, leave buggy stuff with low installation on tracking with #56539, and merge this PR if no new issue gets introduced

jnozsc · 2020-08-10T18:02:11Z

trigger the test again by rebasing on master

jnozsc · 2020-08-11T16:04:50Z

I submit a ticket for grv rgburke/grv#107

jszczuko

Move to version 1.14.7
all looks good

bayandin · 2020-08-11T22:15:23Z

go 1.15 is coming: #59486.
Probably we'll need to move 1.14 to versioned formulae, so we need this update as well.

jnozsc · 2020-08-11T22:18:27Z

I have acknowledged the 1.15 release, the test on 10.15 is almost done (if you check the github action log). Once it finishes, the PR should be ready to review

There should be no new issues introduced, except grv, which I have already submitted the upstream tickets.

For rest of these issues, they are being tracked in #56539 , basically most of them are pending on an upstream release

jnozsc · 2020-08-11T23:17:30Z

10.15

brew install --build-from-source charm
brew install --build-from-source prometheus
brew test --retry --verbose sync_gateway
brew test --retry --verbose termshark
brew install --build-from-source wellington

10.14

Error: 4 failed steps!
brew install --build-from-source charm
brew test --retry --verbose faas-cli
brew install --build-from-source grv
brew install --build-from-source wellington

10.13

Error: 2 failed steps!
brew install --build-from-source charm
brew install --build-from-source wellington

summary

formula	issue	note	fix
charm	project is most likely abandoned from upstream		tracked in homebrew #56539, upstream ticket juju/charmstore-client#209
faas-cli	never happen in previous build, build succeeded, test failed	only on 10.14	flaky test?
grv	build issue	only on 10.14	upstream ticket rgburke/grv#107
prometheus	a network issue when yarn tried to download external resource during the build process	only on 10.15	a temporary issue?
sync_gateway	a flaky test on network issue	only on 10.15	homebrew issue track #56539
wellington	project is most likely abandoned from upstream		tracked in homebrew #56539, upstream ticket wellington/wellington#218

I suggest a merge and handle the leftover in #56539

chenrui333 · 2020-08-12T00:02:38Z

Sounds good with me. Going for the merge now.

chenrui333 · 2020-08-12T00:37:03Z

Just 🚢 it.

chenrui333 previously approved these changes Aug 6, 2020

View reviewed changes

This was referenced Aug 7, 2020

berglas: 0.5.3 repack #59297

Closed

tektoncd-cli: 0.11.0 repack #59300

Closed

Bump gomock to 1.4.4 replicatedhq/ship#1126

Merged

ship: 0.54.1 #59302

Closed

chenrui333 dismissed their stale review via 9e76709 August 8, 2020 16:08

jnozsc force-pushed the bump-go-1.14.7 branch from 9e76709 to 88f4c78 Compare August 8, 2020 16:46

gromgit mentioned this pull request Aug 9, 2020

gitversion: downgrade, use mono. #53092

Merged

5 tasks

jnozsc mentioned this pull request Aug 10, 2020

dashing: fix test #59391

Merged

5 tasks

jnozsc mentioned this pull request Aug 10, 2020

wellington: fix build #59428

Closed

5 tasks

jnozsc and others added 2 commits August 10, 2020 11:01

go 1.14.7

83ab5c4

godep: revision for go

692f62d

jnozsc force-pushed the bump-go-1.14.7 branch from 88f4c78 to 692f62d Compare August 10, 2020 18:01

jnozsc mentioned this pull request Aug 11, 2020

can not build grv on Mojave rgburke/grv#107

Open

jszczuko approved these changes Aug 11, 2020

View reviewed changes

chenrui333 closed this in 6c7fa26 Aug 12, 2020

jnozsc deleted the bump-go-1.14.7 branch August 12, 2020 00:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

go 1.14.7 #59242

go 1.14.7 #59242

jnozsc commented Aug 6, 2020

jnozsc commented Aug 7, 2020 •

edited

Loading

jnozsc commented Aug 7, 2020

chenrui333 commented Aug 8, 2020

jnozsc commented Aug 8, 2020

SMillerDev commented Aug 8, 2020

jnozsc commented Aug 8, 2020

chenrui333 commented Aug 8, 2020 •

edited

Loading

jnozsc commented Aug 8, 2020

chenrui333 commented Aug 8, 2020

jnozsc commented Aug 10, 2020 •

edited

Loading

WZZ1998 commented Aug 10, 2020

jnozsc commented Aug 10, 2020

chenrui333 commented Aug 10, 2020

jnozsc commented Aug 10, 2020

chenrui333 commented Aug 10, 2020

jnozsc commented Aug 10, 2020

jnozsc commented Aug 10, 2020

jnozsc commented Aug 11, 2020 •

edited

Loading

jszczuko left a comment •

edited

Loading

bayandin commented Aug 11, 2020

jnozsc commented Aug 11, 2020 •

edited

Loading

jnozsc commented Aug 11, 2020 •

edited

Loading

chenrui333 commented Aug 12, 2020

chenrui333 commented Aug 12, 2020

go 1.14.7 #59242

go 1.14.7 #59242

Conversation

jnozsc commented Aug 6, 2020

jnozsc commented Aug 7, 2020 • edited Loading

jnozsc commented Aug 7, 2020

chenrui333 commented Aug 8, 2020

jnozsc commented Aug 8, 2020

SMillerDev commented Aug 8, 2020

jnozsc commented Aug 8, 2020

chenrui333 commented Aug 8, 2020 • edited Loading

jnozsc commented Aug 8, 2020

chenrui333 commented Aug 8, 2020

jnozsc commented Aug 10, 2020 • edited Loading

WZZ1998 commented Aug 10, 2020

jnozsc commented Aug 10, 2020

chenrui333 commented Aug 10, 2020

jnozsc commented Aug 10, 2020

chenrui333 commented Aug 10, 2020

jnozsc commented Aug 10, 2020

jnozsc commented Aug 10, 2020

jnozsc commented Aug 11, 2020 • edited Loading

jszczuko left a comment • edited Loading

Choose a reason for hiding this comment

bayandin commented Aug 11, 2020

jnozsc commented Aug 11, 2020 • edited Loading

jnozsc commented Aug 11, 2020 • edited Loading

chenrui333 commented Aug 12, 2020

chenrui333 commented Aug 12, 2020

jnozsc commented Aug 7, 2020 •

edited

Loading

chenrui333 commented Aug 8, 2020 •

edited

Loading

jnozsc commented Aug 10, 2020 •

edited

Loading

jnozsc commented Aug 11, 2020 •

edited

Loading

jszczuko left a comment •

edited

Loading

jnozsc commented Aug 11, 2020 •

edited

Loading

jnozsc commented Aug 11, 2020 •

edited

Loading