Add --no-wait argument
#593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to be a good option to add to systemd in this case. |
This prevents us from looping and waiting for `brew services stop` to finish stopping the service if we just want to attempt once and immediately exit. While we're here, also fix verbose output for `brew services restart`.
|
@SMillerDev Good catch, added. |
Comment on lines
+145
to
+147
| systemctl_args = System.systemctl_args | ||
| if no_wait | ||
| systemctl_args << "--no-block" |
There was a problem hiding this comment.
It doesn't look like the systemctl_args variable is actually used anywhere in this method outside of lines 145 and 147. I assume it's supposed to be used on line 154 as well.
There was a problem hiding this comment.
@apainintheneck Whoops, opened PR in #596
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents us from looping and waiting for
brew services stopto finish stopping the service if we just want to attempt once and immediately exit.While we're here, also fix verbose output for
brew services restart.