Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CD Character Stuff #54

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

revsys413
Copy link
Contributor

@revsys413 revsys413 commented Apr 2, 2024

About the PR

Adds height slider and station records from CD. Tweaks slider parameters slightly for the purposes of our fork. Also, adds custom parameters for species age min/max and appearance thresholds (i.e. "she is a young/middle-aged/old diona", etc) for adjustment in future PRs.

TODO:

  • Port height slider
  • Port character records
  • Port initial records implementation + tweaks and fixes
  • Test it and make sure nothing is horrible and broken
  • Figure out why the height slider snaps and fix it
  • Check CD cryo system vs wizden and try to port records clearing

Small issues:

  • Height slider doesn't go all the way to 0.87 and snaps to 0.90 when saved. This seems to correlate with the character not getting any visually smaller when lowering the slider below 0.90, and snapping to heights throughout. Which is weird, because testing this on Sector Umbra neither of these things seem to happen. (...Honestly, I might just steal their code for this...)
  • Station records do not get unloaded when a player goes into cryo. This is because the CD PR meant to fix this (#159) applies to their own cryo system instead of wizden's implementation. I am going to look into these systems to see if I need to mess with anything (partially because, honestly, ripping out the CD cryo system just to get the build to not error out feels incredibly sloppy). I have a feeling that worst case I can just rip out all of CD's cryo logic but that also feels sloppy. Just, y'know, slightly less sloppy. Nevermind, I don't actually think we need to clear records? Upstream doesn't clear their own records when someone cryo's, so it should be fine.

Why / Balance

roled play

Technical details

See various CD PR's:
cosmatic-drift-14/cosmatic-drift#1
cosmatic-drift-14/cosmatic-drift#162

cosmatic-drift-14/cosmatic-drift#129
cosmatic-drift-14/cosmatic-drift#152
cosmatic-drift-14/cosmatic-drift#159
cosmatic-drift-14/cosmatic-drift#176
cosmatic-drift-14/cosmatic-drift#187
cosmatic-drift-14/cosmatic-drift#205
cosmatic-drift-14/cosmatic-drift#210

Media

Media TK

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

  • add: Implemented Cosmatic Drift character properties.

@revsys413
Copy link
Contributor Author

I fucked up something in git oops

@nearlyNonexistent
Copy link
Contributor

Can you please replace the "port [whatever] PR" with an explanation of what the contents of the PRs are?

@nearlyNonexistent nearlyNonexistent added the enhancement New feature or request label Apr 3, 2024
@nearlyNonexistent nearlyNonexistent added the port porting content from another fork label Apr 3, 2024
@revsys413
Copy link
Contributor Author

Can you please replace the "port [whatever] PR" with an explanation of what the contents of the PRs are?

Done (I originally had those more descriptive, but changed them to personally keep track of which ones i still needed to do)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request port porting content from another fork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants