Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unroll GridArray setindex! with @nexprs #44

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Conversation

lcw
Copy link
Collaborator

@lcw lcw commented Jul 22, 2023

This works around a julia bug that is causing this code to be slow to
compile on AMD systems.

This also seems to fix #42.

This works around a julia bug that is causing this code to be slow to
compile.
@lcw lcw force-pushed the lcw/slowcompileworkaround branch from 2ceeb12 to 9388e06 Compare July 22, 2023 20:46
@lcw lcw merged commit 46b4bba into master Jul 22, 2023
13 checks passed
@lcw
Copy link
Collaborator Author

lcw commented Jul 22, 2023

I have filed an issue with KA JuliaGPU/KernelAbstractions.jl#411 highlighting the problem we are experiencing with @unroll.

@lcw lcw deleted the lcw/slowcompileworkaround branch July 23, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI on Julia 1.10 is taking a long time compared to 1.9
1 participant