-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure session data is always returned #1412
Conversation
🦋 Changeset detectedLatest commit: 5e69c69 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for houdini-docs-next canceled.
|
✅ Deploy Preview for houdinigraphql canceled.
|
@AlecAivazis I was able to successfully test this against the test project from the original issue. Steps for testing were: # clone and setup houdini
git clone [email protected]:HoudiniGraphql/houdini.git
pnpm i
# build on main to replicate original issue
pnpm build
# install local houdini-svelte in test project
npm i ../houdini/packages/houdini-svelte/
# verify the server outputs "fetchParams session {}"
npm run dev
# checkout this branch
git checkout root-layout-load
# rebuild houdini-svelte - I used some extra options here because I was getting some issues with old code being cached
pnpm i && pnpm build --no-cache --force
# re-install local houdini-svelte in test project
npm i ../houdini/packages/houdini-svelte/
# verify the server outputs "fetchParams session { token: 'asdf' }"
npm run dev I was able to successfully switch between main and this branch with expected results several times using this method 👍 |
Thanks for the detailed summary of the steps you took @Rudedog9d! |
Fixes #1405
This PR fixes an issue with the transformation of the root layout if it included an early return. Previously the logic would look for a single value returned but now we look for any return in the function and ensure that the necessary values are included
cc @Rudedog9d
To help everyone out, please make sure your PR does the following:
pnpm run tests
andcd integration && pnpm run tests
pnpm changeset