Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip albums flag and redditdownload.py improvements #23

Merged
merged 2 commits into from Oct 3, 2015
Merged

Skip albums flag and redditdownload.py improvements #23

merged 2 commits into from Oct 3, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jan 24, 2015

Hey I saw issue #17 requesting an argument to skip album downloads so I thought I would implement that, while doing so I also added a couple more things I thought would improve the script. Here is what I did:

  • Added -skipAlbums flag to skip all albums(obviously).
  • Change from checking for only 'imgur.com/a/' in urls to also checking for 'imgur.com/gallery' so they can now be scraped too.
  • Check if url is to a reddit comments page and if so move on to next url instead of attemping to scrape and inevitably failing.

I thought they would all be usefull but only add the ones you want if you think otherwise.

rachmadaniHaryono added a commit to rachmadaniHaryono/RedditImageGrab that referenced this pull request Aug 6, 2015
@HoverHell HoverHell merged commit 83dc8bf into HoverHell:master Oct 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant