Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes c-common and d-messenger #30

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

axbuglak
Copy link

@axbuglak axbuglak commented Sep 2, 2023

Changes in c-common

  • Fixed db requests in api(must be asynchronous)
  • Fixed delete request in to the db(quotes changed from '' to ``)
  • Fixed http requests (props must be destructured so that they will not be in an array in api's functions)

Changes in d-messenger

  • Fixed http requests (props must be destructured so that they will not be in an array in api's functions)
  • Fixed sql questions in the crud in d-messenger (if table names are written from upper letter, postgresql will understand this only when table names are in quotes)

@axbuglak axbuglak changed the title fix http not PUT req fix c-common Sep 3, 2023
@axbuglak axbuglak changed the title fix c-common fixes c-common and d-messenger Dec 5, 2023
@JaoodxD
Copy link

JaoodxD commented Dec 6, 2023

As Far as I know there's the linter rule to force parenthesis around arrow function params.
So some of the changes like following should be reverted

904ead5#diff-d69b4849eedd14f001029f96465f3d351b5a43cbc9ffce2c15dd96608f5fef39R5

Here is mentioned linter rule:
https://github.com/HowProgrammingWorks/DDD/blob/master/.eslintrc.json#L214-L216

@axbuglak
Copy link
Author

axbuglak commented Dec 6, 2023

@JaoodxD
Yes, you are right. For unknown to me reasons the code was formatted using wrong eslint config(with arrow-parens: as-needed). So its already fixed. Thank you for the comment/review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants