Update main vote analyzer to also handle special vote titles #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is helpful not only in scraper tests, but for analyzers etc., too!
Until now, we’ve decided whether a vote is a main vote solely based on the description of a vote. However, in rare cases a main vote may not have description and only a title (e.g. in case of the election of the Commission). I’ve updated the analyzer to handle votes based on title in addition to the existing heuristic.
|
Looks good! Danke! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, we’ve decided whether a vote is a main vote solely based on the description of a vote. However, in rare cases a main vote may not have description and only a title (e.g. in case of the election of the Commission). I’ve updated the analyzer to handle votes based on title in addition to the existing heuristic.