Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow the receiver to operate with delayed metrics #40

Merged
merged 1 commit into from
Aug 29, 2024
Merged

allow the receiver to operate with delayed metrics #40

merged 1 commit into from
Aug 29, 2024

Conversation

narcis96
Copy link

No description provided.

@narcis96 narcis96 force-pushed the narcis/fix_todos branch 4 times, most recently from 6e08caf to 0b04368 Compare August 23, 2024 08:13
@narcis96 narcis96 changed the title solve TODOs allow the receiver to opperate with delayed metrics Aug 23, 2024
@narcis96 narcis96 force-pushed the narcis/fix_todos branch 4 times, most recently from 6ab42aa to 0317615 Compare August 23, 2024 10:24
heitorganzeli
heitorganzeli requested changes Aug 23, 2024
View reviewed changes
Copy link

@heitorganzeli heitorganzeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few things to update. great work overall

receiver/huaweicloudcesreceiver/README.md Outdated Show resolved Hide resolved
receiver/huaweicloudcesreceiver/receiver.go Show resolved Hide resolved
receiver/huaweicloudcesreceiver/receiver.go Outdated Show resolved Hide resolved
receiver/huaweicloudcesreceiver/receiver.go Show resolved Hide resolved
@narcis96 narcis96 changed the title allow the receiver to opperate with delayed metrics allow the receiver to operate with delayed metrics Aug 26, 2024
@narcis96 narcis96 force-pushed the narcis/fix_todos branch 4 times, most recently from 633fbec to d3ed27e Compare August 28, 2024 11:56
@narcis96 narcis96 closed this Aug 29, 2024
@narcis96 narcis96 reopened this Aug 29, 2024
@narcis96 narcis96 force-pushed the narcis/fix_todos branch 2 times, most recently from 36bd760 to 52875e6 Compare August 29, 2024 10:01
heitorganzeli
heitorganzeli reviewed Aug 29, 2024
View reviewed changes
Copy link

@heitorganzeli heitorganzeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small things

receiver/huaweicloudcesreceiver/internal/backoff_test.go Outdated Show resolved Hide resolved
receiver/huaweicloudcesreceiver/internal/backoff_test.go Outdated Show resolved Hide resolved
receiver/huaweicloudcesreceiver/internal/backoff_test.go Show resolved Hide resolved
@narcis96 narcis96 force-pushed the narcis/fix_todos branch 2 times, most recently from 257350f to a7b58e3 Compare August 29, 2024 14:51
@heitorganzeli heitorganzeli merged commit 6926554 into main Aug 29, 2024
141 of 147 checks passed
@narcis96 narcis96 deleted the narcis/fix_todos branch September 4, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heitorganzeli heitorganzeli heitorganzeli requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@narcis96 @heitorganzeli