Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use go mod #14

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

use go mod #14

wants to merge 4 commits into from

Conversation

houz42
Copy link

@houz42 houz42 commented Jan 6, 2021

and monor fixes to pass go lint checkings

@houz42 houz42 mentioned this pull request Jan 6, 2021
@doubletao318
Copy link
Collaborator

  1. Thank you so much for your efforts. But we need to try this with our own env.
  2. The versions of the 3rd packages may not meet our requirements and need to be reviewed.
  3. There are some conflicts.

@houz42
Copy link
Author

houz42 commented Jan 29, 2021

@doubletao318 Conflects fixed, and thanks for your patient.

And yes, as there was no any requirements configuration file as descripted in the go mod init doc, there must be some differencies between the versions of the 3rd party packages. And it should be tested carefully. Hopefully, we have tried with no suprise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants